sketchbook: behavior.SetFiltersDisabled counts as a move

Case number:699969-2005475
Opened by:LociOiling
Opened on:Saturday, July 7, 2018 - 18:21
Last modified:Monday, July 30, 2018 - 21:28

I noticed that some common recipes leak moves before they display an initial dialog.

It turns out that SetFiltersDisabled is the culprit. Recipes may check the filter bonus by first enabling filters (just to be sure), getting the score, disabling the filters and getting the score, then enabling the filters again. The current filter bonus is the difference in the two scores, but the recipe just leaked three moves without doing anything.

Administrative calls like behavior.SetFiltersDisabled shouldn't deduct moves.

This problem is easy to work around with quicksave and quickload.

The following one-line recipes demonstrates the issue:

(Sat, 07/07/2018 - 18:21  |  5 comments)

Joined: 12/27/2012

The function save.LoadSecondaryStructure also takes a move. Setting the secondary structure manually or using structure.SetSecondaryStructure doesn't cost moves.

jflat06's picture
User offline. Last seen 21 hours 19 min ago. Offline
Joined: 09/29/2010
Groups: Window Group

This should be fixed in the latest devprev - thanks for the report!

Joined: 12/27/2012

Fast work, SetFiltersDisabled no longer costs a move in devprev.

However, save.LoadSecondaryStructure () is still costing a move. Changing secondary structure manually does not cost anything. I missed this previously, but loading secondary structures via control + 9 also costs a move.

The new structure.SetSecondaryStructureSelected ( "a" ) seems to work, and does not cost a move.

I think save.LoadSecondaryStructure () and ctrl-9 should be free.

Joined: 12/27/2012

In 20180725-d14dae34c3-win_x86-devprev, behavior.SetFiltersDisabled(false) no longer costs a move, but save.LoadSecondaryStructure () and ctrl-9 do use a move.

Joined: 12/27/2012
Status: Open » Closed

Closing this one out, see for the LoadSecondaryStructure part of the problem.


Developed by: UW Center for Game Science, UW Institute for Protein Design, Northeastern University, Vanderbilt University Meiler Lab, UC Davis
Supported by: DARPA, NSF, NIH, HHMI, Amazon, Microsoft, Adobe, Boehringer Ingelheim, RosettaCommons