Crash if dialog.Show is given wrong argument

Case number:845829-994346
Topic:Crash/Hang
Opened by:truestone
Status:Open
Type:Bug
Opened on:Friday, January 18, 2013 - 19:14
Last modified:Thursday, January 24, 2013 - 20:31

The program aborts when dialog.Show is accidentally passed a table value that is not a dialog. For instance this LuaV2 recipe crashes the program:

dialog.Show({})

(Fri, 01/18/2013 - 19:14  |  4 comments)
»
  • 0


Tue, 01/22/2013 - 19:33
#1
 katfish 46 1295
katfish's picture
User offline. Last seen 7 years 38 weeks ago. Offline
Joined: 01/09/2013
Groups: Cell Biology Fall 2014 with Smith
Status: Open » Open

Thank you for your report, truestone. We are working on getting this resolved presently.

Top
  • 0
Wed, 01/23/2013 - 04:30
#2
brow42 46 1295
brow42's picture
User offline. Last seen 2 years 8 weeks ago. Offline
Joined: 09/19/2011
Groups: None

If you fix this one, you should fix all of the dialog functions and error() which all crash the client if the arguments are the wrong type.

Top
  • 0
Thu, 01/24/2013 - 20:31
#3
truestone 46 1295
truestone's picture
User offline. Last seen 9 years 11 weeks ago. Offline
Joined: 03/18/2012
Groups: Gargleblasters

Well, I'll consider myself lucky then that is was the first time I crashed foldit due to a script error. Type errors such as passing nil (i.e. a mistype variable name) seem to be cleanly intercepted.

Top
  • 0
Wed, 01/23/2013 - 17:40
#4
 katfish 46 1295
katfish's picture
User offline. Last seen 7 years 38 weeks ago. Offline
Joined: 01/09/2013
Groups: Cell Biology Fall 2014 with Smith

Thanks, brow42. We are looking into it.

Top
  • 0
Sitemap

Developed by: UW Center for Game Science, UW Institute for Protein Design, Northeastern University, Vanderbilt University Meiler Lab, UC Davis
Supported by: DARPA, NSF, NIH, HHMI, Amazon, Microsoft, Adobe, Boehringer Ingelheim, RosettaCommons